Skip to content

Conversation

@rtuck99
Copy link
Contributor

@rtuck99 rtuck99 commented Jun 30, 2025

Fixes broken a system test in test_load_centre_collect_full_plan due to a change in the robot load callback implementation in

Link to dodal PR (if required): #N/A
(remember to update pyproject.toml with the dodal commit tag if you need it for tests to pass!)

Instructions to reviewer on how to test:

  1. Do thing x
  2. Confirm thing y happens

Checks for reviewer

  • Would the PR title make sense to a user on a set of release notes

@rtuck99 rtuck99 requested a review from a team as a code owner June 30, 2025 15:33
@codecov
Copy link

codecov bot commented Jun 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.92%. Comparing base (f66b267) to head (75cf8db).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1142   +/-   ##
=======================================
  Coverage   88.92%   88.92%           
=======================================
  Files         118      118           
  Lines        7416     7416           
=======================================
  Hits         6595     6595           
  Misses        821      821           
Components Coverage Δ
i24 SSX 75.58% <ø> (ø)
hyperion 96.80% <ø> (ø)
other 97.98% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@DominicOram DominicOram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@DominicOram DominicOram merged commit f79a63f into main Jul 1, 2025
22 checks passed
@DominicOram DominicOram deleted the fix_broken_system_tests branch July 1, 2025 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants