Add external triggering jungfrau plan#1202
Conversation
DominicOram
left a comment
There was a problem hiding this comment.
Thanks, couple of comments in code. Do we also need to add the jungfrau to dodal.beamlines.i24?
| from mx_bluesky.common.utils.log import LOGGER | ||
|
|
||
|
|
||
| def do_external_acquisition( |
There was a problem hiding this comment.
Should: I'm not sure how useful this plan is in isolation because to get the external triggering working we will need to set the zebra up etc. The issue also says that the first one to start with is do_manual_acquisition, which is an internal acquisition, not an external one, like the rotation
There was a problem hiding this comment.
You're right, this plan probably isn't useful as an entry point. I won't add it to the BlueAPI i24 entry plans. We will still need to use it within other plans though.
Yes, I seem to have got mixed up between external and internal triggering at some point during this PR... I will make another one for internal triggering now
I just added a draft PR here. Not sure what the prefix is / the number of odin nodes / the default path + filename to use yet though |
…ce/mx-bluesky into 1200_add_basic_jf_plans
DominicOram
left a comment
There was a problem hiding this comment.
Looks good, thanks. I think we need to get the ophyd-async one merged and released first then we can do this one
|
Once this CI passes I will merge this PR. The plan here is outdated compared to the one tested on i24, but that is addressed in #1216 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1202 +/- ##
==========================================
+ Coverage 90.10% 90.14% +0.03%
==========================================
Files 129 130 +1
Lines 7802 7830 +28
==========================================
+ Hits 7030 7058 +28
Misses 772 772
🚀 New features to boost your workflow:
|
CI will fail as the jungfrau isn't merged into ophyd-async yet.
Begins #1200
Requires:
Instructions to reviewer on how to test:
Checks for reviewer