Add Jungfrau do pedestal darks plans#1219
Conversation
…ce/mx-bluesky into 1200_add_basic_jf_plans
|
I think this is in a mergable state now? WIll do an ophyd-async release next week so CI can pass |
DominicOram
left a comment
There was a problem hiding this comment.
I think this is in a mergable state now? WIll do an ophyd-async release next week so CI can pass
ophyd-async release done so I think we just need to add the small tests and fix the failing CI
|
|
||
| @patch("mx_bluesky.beamlines.i24.jungfrau_commissioning.do_darks.override_file_path") | ||
| @patch("bluesky.plan_stubs.unstage") | ||
| async def test_jungfrau_unstage( |
There was a problem hiding this comment.
Nit:
| async def test_jungfrau_unstage( | |
| async def test_jungfrau_unstaged_when_plan_in_error( |
|
|
||
|
|
||
| @patch("mx_bluesky.beamlines.i24.jungfrau_commissioning.do_darks.override_file_path") | ||
| async def test_full_do_pedestal_darks( |
There was a problem hiding this comment.
If they win then we should add them in
|
Couple of bugs caught from last bit of testing:
Sort of thinking about extending |
DominicOram
left a comment
There was a problem hiding this comment.
As discussed, can we move the stage out of fly_jungfrau, instead plans that call fly_jungfrau should first do @bpp.stage_decorator([jungfrau]). do_pedestal_darks can then set the pedestal PVs itself. We should add a comment in fly_jungfrau to say it should be staged.
DominicOram
left a comment
There was a problem hiding this comment.
Great, thanks. One comment. Also do_internal_acquisition and do_external_acquisition should probably include the stage decorators.
We decided that these are plans stubs so the staging goes in whatever plan is using them |
Part of #1200
This adds the pedestal dark plan. Note that we will need a new release of ophyd-async (for bluesky/ophyd-async@15fa34b) for this plan to actually work on the beamline
/dls_sw/i24/software/bluesky/jungfrau_25Checks for reviewer