Use daq config server for UndulatorDCM config#1497
Open
Conversation
c4613e8 to
7c21294
Compare
7c21294 to
0ec62f4
Compare
4 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1497 +/- ##
=======================================
Coverage 92.32% 92.32%
=======================================
Files 143 143
Lines 8126 8131 +5
=======================================
+ Hits 7502 7507 +5
Misses 624 624
🚀 New features to boost your workflow:
|
rtuck99
reviewed
Jan 27, 2026
Contributor
rtuck99
left a comment
There was a problem hiding this comment.
Looks fine to me, however would be nice to see some minimal system tests with the config server so that we can verify we can read configs. I think also that having such tests also does help with thinking about endpoint configuration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1494
Link to dodal PR (if required): DiamondLightSource/dodal#1768
Reads
UndulatorDCMconfig through the config server.Instructions to reviewer on how to test:
Checks for reviewer