Read beamline parameters through config server#1511
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1511 +/- ##
==========================================
+ Coverage 92.86% 92.87% +0.01%
==========================================
Files 153 153
Lines 8645 8646 +1
==========================================
+ Hits 8028 8030 +2
+ Misses 617 616 -1
🚀 New features to boost your workflow:
|
DominicOram
left a comment
There was a problem hiding this comment.
Thanks, looks good.
Could: It feels like there's some general tidying up we can do here, but maybe that would be easier after the other moves to using the config server. For example:
- Why do we have a separate MX config server client that we use sometimes?
- The way we patch
"dodal.common.beamlines.beamline_parameters.BEAMLINE_PARAMETER_PATHS",inmx-blueskyis quite odd in that we use i03 for everything and we just patch it all the time rather than patching what we need when we need it
tests/conftest.py
Outdated
| yield | ||
|
|
||
|
|
||
| def _fake_config_server_get_file_contents( |
There was a problem hiding this comment.
Should: Can we not combine this and _fake_config_server_read?
244a5bc to
26aa661
Compare
|
We have an MX config client which directly reads the the filesystem if the server is down. I think this is no longer viable since the server now does conversions, so we'd have to build that same functionality into the MX config client. Discussed with @olliesilvester a few times and we came to the conclusion we'd delete this, particularly as i03 are happy to use the config server for Hyperion now it's deployed on their beamline cluster. I think you're right though, it would be easier to do this and other tidying once all the config server PRs are in. |
f0290db to
095a052
Compare
Fixes #1504
Link to dodal PR (if required): DiamondLightSource/dodal#1773
(remember to update
pyproject.tomlwith the dodal commit tag if you need it for tests to pass!)Instructions to reviewer on how to test:
Checks for reviewer