debug and file log handler support for hyperion-blueapi#1630
Open
debug and file log handler support for hyperion-blueapi#1630
hyperion-blueapi#1630Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1630 +/- ##
==========================================
+ Coverage 92.86% 92.87% +0.01%
==========================================
Files 153 154 +1
Lines 8645 8660 +15
==========================================
+ Hits 8028 8043 +15
Misses 617 617
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1377
Adds debug and file log handler support for
hyperion-blueapiThe behaviour of LOG_DIR and DEBUG_LOG_DIR has changed slightly - previously if not specified then the log file location would be calculated from the
BEAMLINEenvironment variable as/dls_sw/<beamline>logs/blueskyand/dls/tmp/<beamline>/logs/blueskyrespectively, now it requires both environment variables to be specified explicitly.The
run_hyperion.shlauncher script has been updated accordingly which should result in no change in normal usage, however this should reduce the potential to accidentally write to the wrong file locations in test.Link to dodal PR (if required): #N/A
(remember to update
pyproject.tomlwith the dodal commit tag if you need it for tests to pass!)Instructions to reviewer on how to test:
Checks for reviewer