Skip to content

Multipin snapshot fix#1753

Merged
rtuck99 merged 3 commits into
mainfrom
multipin_snapshot_fix
Jun 29, 2026
Merged

Multipin snapshot fix#1753
rtuck99 merged 3 commits into
mainfrom
multipin_snapshot_fix

Conversation

@rtuck99

@rtuck99 rtuck99 commented May 18, 2026

Copy link
Copy Markdown
Contributor

Fixes #1727

Link to dodal PR (if required): #N/A
(remember to update pyproject.toml with the dodal commit tag if you need it for tests to pass!)

Instructions to reviewer on how to test:

  1. Tests pass
  2. Multipin collections perform snapshot generation instead of capturing separate snapshots

Checks for reviewer

  • Would the PR title make sense to a user on a set of release notes

@rtuck99 rtuck99 added the hyperion Issues for Hyperion, the Bluesky UDC stack label May 18, 2026
@codecov

codecov Bot commented May 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.03%. Comparing base (bff8d34) to head (9d71e12).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1753   +/-   ##
=======================================
  Coverage   93.03%   93.03%           
=======================================
  Files         164      164           
  Lines        8927     8931    +4     
=======================================
+ Hits         8305     8309    +4     
  Misses        622      622           
Components Coverage Δ
i24 SSX 77.16% <ø> (ø)
hyperion 98.74% <100.00%> (+<0.01%) ⬆️
other 98.16% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rtuck99 rtuck99 marked this pull request as ready for review May 18, 2026 16:24
@rtuck99 rtuck99 requested a review from a team as a code owner May 18, 2026 16:24
Base automatically changed from update_mx_bluesky_for_ophyd_async_0_17 to main May 19, 2026 09:09
@rtuck99 rtuck99 force-pushed the multipin_snapshot_fix branch from 1625ae7 to aa6c6f3 Compare June 25, 2026 14:06

@phathaway phathaway left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consistent with PR spec

@rtuck99 rtuck99 enabled auto-merge (squash) June 29, 2026 08:57
@rtuck99 rtuck99 merged commit 21f9fed into main Jun 29, 2026
16 checks passed
@rtuck99 rtuck99 deleted the multipin_snapshot_fix branch June 29, 2026 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hyperion Issues for Hyperion, the Bluesky UDC stack

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multipin collections should be generating rotation snapshots from gridscan snapshots

2 participants