47 adding coordinate system #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
July 9, 2025 16:36
noemifrisina
requested changes
Jul 22, 2025
Contributor
noemifrisina
left a comment
noemifrisina
left a comment
There was a problem hiding this comment.
Looks good, thanks, just a couple of comments.
Right now the tab rendering is slightly off as Preset Positions ends up on top of the footer. Properly tidying up the screen is a separate PR - but for the sake of this one I'd say we need to have the Coordinate System buttons be a bit smaller (only in height).
We won't be able to properly test till we have some time on the beamline but the plan calls seem right.
Contributor
Author
|
Changed buttons to be smaller but also added #57 for a more permanent solution to the problem in the future. Fixed text of the dialog box. Also moved the oxford chip diagram to src/assets instead of public to join the Diamond logo icon. |
noemifrisina
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue: #47
Added coordinate system and dialog box that explains what the buttons do.