Add a working Navbar #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
For the navbar, adding linkComponent to the logo will prevent it from reloading the entire page whenever the logo is clicked. |
Contributor
Author
Done, thanks! |
adaudon
requested changes
Sep 17, 2025
Contributor
adaudon
left a comment
adaudon
left a comment
There was a problem hiding this comment.
A few small changes to consider before merging.
src/routes/BeamlineI24.tsx
Outdated
|
|
||
| export function BeamlineI24() { | ||
| const theme = useTheme(); | ||
| const [value, setValue] = React.useState(0); |
Contributor
There was a problem hiding this comment.
Small change. But changing the name of the variable from value to something more easier to read like [tab, setTab] would be more helpful.
Contributor
Author
There was a problem hiding this comment.
fair enough, done
Co-authored-by: Tamoor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #67
Spawned #69