Skip to content

Conversation

@adaudon
Copy link
Contributor

@adaudon adaudon commented Oct 24, 2025

Fixed #79

Moved exports that weren't React components into helper files.

@adaudon adaudon requested a review from a team as a code owner October 24, 2025 12:21
@adaudon
Copy link
Contributor Author

adaudon commented Oct 24, 2025

While moving the functions, I noticed that for the function useContainerDimensions , the width and height are both set as offsetwidth. I was wondering if that was intentional or a typo.

@adaudon adaudon requested a review from noemifrisina October 27, 2025 15:24
@noemifrisina
Copy link
Contributor

Also, there are now two copies of parseInstrumentSession and readVisitFromPvas they had already been moved to another file (visit.ts in a previous PR - please remove one

@adaudon adaudon requested a review from noemifrisina October 28, 2025 16:25
@adaudon adaudon merged commit 072eaee into main Oct 29, 2025
10 checks passed
@adaudon adaudon deleted the 79-Separate_exports branch October 29, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Separate files that export both components and variables

3 participants