Skip to content

Conversation

@adaudon
Copy link
Contributor

@adaudon adaudon commented Oct 30, 2025

Fixes #81

Now imports are absolute pathing when appropriate.

@adaudon adaudon requested a review from a team as a code owner October 30, 2025 11:27
Copy link
Contributor

@noemifrisina noemifrisina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a fresh install on this branch, it looks like something in this change breaks things as it can't find the index.html file anymore
(there's a couple of other errors too but this seems to be the main one).

Error:   Failed to scan for dependencies from entries:
  /scratch/uhz96441/workspaces/mx/mx-daq-ui/index.html

  ✘ [ERROR] ENOENT: no such file or directory, open '/scratch/uhz96441/workspaces/mx/mx-daq-ui/src/scratch/uhz96441/workspaces/mx/mx-daq-ui/index.html' [plugin vite:dep-scan]

    node_modules/esbuild/lib/main.js:1275:21:
      1275 │         let result = await callback({
           ╵                      ^

    at async open (node:internal/fs/promises:642:25)
    at async Object.readFile (node:internal/fs/promises:1279:14)
    at async htmlTypeOnLoadCallback (file:///scratch/uhz96441/workspaces/mx/mx-daq-ui/node_modules/vite/dist/node/chunks/dep-D_zLpgQd.js:49701:19)
    at async requestCallbacks.on-load (/scratch/uhz96441/workspaces/mx/mx-daq-ui/node_modules/esbuild/lib/main.js:1275:22)
    at async handleRequest (/scratch/uhz96441/workspaces/mx/mx-daq-ui/node_modules/esbuild/lib/main.js:647:11)

  This error came from the "onLoad" callback registered here:

    node_modules/esbuild/lib/main.js:1150:20:
      1150 │       let promise = setup({
           ╵                     ^

    at setup (file:///scratch/uhz96441/workspaces/mx/mx-daq-ui/node_modules/vite/dist/node/chunks/dep-D_zLpgQd.js:49781:13)
    at handlePlugins (/scratch/uhz96441/workspaces/mx/mx-daq-ui/node_modules/esbuild/lib/main.js:1150:21)
    at buildOrContextImpl (/scratch/uhz96441/workspaces/mx/mx-daq-ui/node_modules/esbuild/lib/main.js:873:5)
    at Object.buildOrContext (/scratch/uhz96441/workspaces/mx/mx-daq-ui/node_modules/esbuild/lib/main.js:699:5)
    at /scratch/uhz96441/workspaces/mx/mx-daq-ui/node_modules/esbuild/lib/main.js:2032:68
    at new Promise (<anonymous>)
    at Object.context (/scratch/uhz96441/workspaces/mx/mx-daq-ui/node_modules/esbuild/lib/main.js:2032:27)
    at Object.context (/scratch/uhz96441/workspaces/mx/mx-daq-ui/node_modules/esbuild/lib/main.js:1874:58)
    at prepareEsbuildScanner (file:///scratch/uhz96441/workspaces/mx/mx-daq-ui/node_modules/vite/dist/node/chunks/dep-D_zLpgQd.js:49576:24)

  The plugin "vite:dep-scan" was triggered by this import

    <stdin>:1:7:
      1 │ import "/scratch/uhz96441/workspaces/mx/mx-daq-ui/index.html"
        ╵        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

@adaudon adaudon requested a review from noemifrisina October 31, 2025 14:48
Copy link
Contributor

@noemifrisina noemifrisina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It now seems to be okay, thanks

@adaudon adaudon merged commit 0824b5a into main Oct 31, 2025
10 checks passed
@adaudon adaudon deleted the 81-Add_baseurl branch October 31, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add baseurl to tsconfig

3 participants