-
Notifications
You must be signed in to change notification settings - Fork 5
Fix for lattice energy UnitConv bug #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #144 +/- ##
==========================================
- Coverage 99.48% 99.11% -0.38%
==========================================
Files 12 12
Lines 775 788 +13
==========================================
+ Hits 771 781 +10
- Misses 4 7 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Switch to (up/down)load-artifact@v4 as v3 is now fully deprecated - Ensure all of the build artifacts have unique names as v4 doesn't support multiple artifacts with the same name - Drop Python 3.7 from the CI matrix as v4 doesn't support it - Fix a couple of docstrings to resolve linting check failure
|
Ok, CI failures are resolved and I've cleaned up the commit history so this is ready to merge However, we should get Pytac properly on the latest Copier template at some point |
|
I agree that we need to convert this to copier template, probably a job for me alongside converting slow feedbacks. |
MJGaughran
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you've both highlighted several existing problems in pytac (e.g. with type hinting), but I agree that this PR is not making things worse than before.
Otherwise, it all looks fine.
Also a bonus commit used by Python BBA