Skip to content

Conversation

@tieneupin
Copy link
Contributor

@tieneupin tieneupin commented Oct 28, 2024

When referring to the Textual demo app, it does not once call an explicit exit(), relying instead on self.exit() to close itself. This seems to be the cause of the raised I/OErrors when we try to quit the Murfey app.

Credits to: @stephen-riggs

@codecov
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.38%. Comparing base (9e7539a) to head (4c6eeb9).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #388      +/-   ##
==========================================
+ Coverage   28.37%   28.38%   +0.01%     
==========================================
  Files          71       71              
  Lines        9608     9603       -5     
  Branches     1284     1284              
==========================================
  Hits         2726     2726              
+ Misses       6788     6783       -5     
  Partials       94       94              

@tieneupin
Copy link
Contributor Author

This PR should be merged together with, but before PR #360 in order to properly fix MSYS2 functionality.

@tieneupin tieneupin self-assigned this Nov 1, 2024
@tieneupin tieneupin added bug Something isn't working client Relates to the client component labels Nov 1, 2024
@tieneupin tieneupin merged commit 975e2cb into main Nov 1, 2024
17 checks passed
@tieneupin tieneupin deleted the tui-app-fix branch November 1, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working client Relates to the client component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants