Skip to content

Add signal generator device #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Add signal generator device #197

wants to merge 2 commits into from

Conversation

callumforrester
Copy link
Contributor

Changes:

  • Add device that generates a sine wave with a gated trigger
  • Make basic IOC and EDM UI for device

@callumforrester
Copy link
Contributor Author

TODO: Add tests

@abbiemery
Copy link
Collaborator

I like having the edm ui but I don't think it belongs here. I don't really want anything in here that needs external setup and config to be run. In which case I'd suggest moving the signal generator and screen to tickit-devices, and just making this pr the relevant changes to epics adapter.

abbiemery
abbiemery requested changes Nov 23, 2023
View reviewed changes
Copy link
Collaborator

@abbiemery abbiemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous comment.

@callumforrester
Copy link
Contributor Author

Have moved to tickit devices DiamondLightSource/tickit-devices#99 and created a new PR for the epics adapter changes: #198. So will close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abbiemery abbiemery abbiemery requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@callumforrester @abbiemery