Skip to content

Fix/wal fatal on failure #1577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

suhailroushan13
Copy link
Contributor

fix: exit on WAL initialization failure to prevent data corruption

🔍 Overview

  • Added a fatal log and immediate shutdown if WAL initialization fails.
  • Prevents running in a corrupted state where data persistence is uncertain.
  • Improves debugging by making WAL failures explicit.
  • Reduces silent failures that could lead to data loss or unexpected crashes.

🛠️ Impact

✅ Ensures data durability by stopping execution when WAL fails.
✅ Helps debug issues faster by logging a clear fatal error.
✅ Prevents unintended behaviors due to partial WAL initialization.

🔄 Before vs After

Before:

  • Logs an error but allows the server to continue running.
  • Could lead to unexpected failures when WAL is required.

After:

  • Immediately exits with a fatal error message.
  • Ensures the database does not start in an unsafe state.

@CLAassistant
Copy link

CLAassistant commented Mar 20, 2025

CLA assistant check
All committers have signed the CLA.

@arpitbbhayani
Copy link
Contributor

Please remove the Lincese Script changes from this PR.

@arpitbbhayani
Copy link
Contributor

@suhailroushan13 any updates?

@suhailroushan13
Copy link
Contributor Author

Apologies for that — I’ve removed the license script changes from this PR as requested.
Let me know if there’s anything else I should update!

@arpitbbhayani
Copy link
Contributor

@suhailroushan13 because of last merge of your changes in license file, there are conflicts here. You will need to pull the latest changes and update this PR. This is gtg, I will merge it as soon as you resolve the conflicts. THanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants