Added GEOADD, GEODIST, GEOSEARCH commands #1742
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bipoool is this a WIP or good for a review? |
|
GEOADD, GEODIST are done and tested. |
|
Hey @arpitbbhayani |
bipoool
commented
May 23, 2025
There was a problem hiding this comment.
Hey @arpitbbhayani
I've created a geo type as discussed
Will add more commands and links soon
bipoool
commented
May 23, 2025
internal/types/geo.go
Outdated
| } | ||
|
|
||
| // This returns all the nodes which are in the given shape | ||
| func (geoReg *GeoRegistry) GeoSearchElementsWithinShape(params map[Param]string, nonParams []string) ([]*wire.GEOElement, error) { |
There was a problem hiding this comment.
This function is still large due to the validation part
Should I break the validation and search part into different functions?
bipoool
force-pushed
the
feature/geo-commands
branch
from
f5650f1 to
fa454ed
Compare
|
Hey @arpitbbhayani |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other related PRs -
DiceDB-Protos PR - DiceDB/dicedb-protos#7
DiceDB-GO PR - DiceDB/dicedb-go#18
DiceDB-CLI PR - DiceDB/dicedb-cli#48