Fix audio playback by updating librespot to v0.8.0 #38
Conversation
which includes the fix in librespot-org/librespot#1622
| SpotifyId::from_base62(id).ok().map(|track| { | ||
| Command::PlayerLoad { | ||
| track, | ||
| track: SpotifyUri::Track { id: track }, |
There was a problem hiding this comment.
The reason for this change is because player.load and player.preload now take in SpotifyUris instead of SpotifyIds.
We could do the wrap just before we call player.load however I thought it made more sense to do the wrap here and have our Commands explicitly use the new type.
|
@Diegovsky please see fix, it's currently breaking the app. |
Diegovsky
left a comment
Diegovsky
left a comment
There was a problem hiding this comment.
Nice work! Thanks for submitting this
|
@Diegovsky I think you also need to approve the flatpak workflow before this PR can get submitted. |
|
Hey there. Got some little time in this mess that is the final parts of the semester. I just allowed it to run and waiting to properly merge this. Btw: I was working on some stuff to integrate librespot git version but it really is better to go like this and use a proper version. Thank you all for the patience and care during this process. |
|
Sure, it didn't work but that is because flatpak builds need the cargo sources to be generated. I'll merge this in dev and deal with it myself. Thank you for the PR! |
3 participants
which includes the fix in librespot-org/librespot#1622