Update the URL for the pure javascript implementation, added a Dockerfile & fixed just a pure port not working - #6
Open
axodouble wants to merge 4 commits into
Open
Update the URL for the pure javascript implementation, added a Dockerfile & fixed just a pure port not working #6axodouble wants to merge 4 commits into
axodouble wants to merge 4 commits into
Conversation
Author
|
I have also created this tree on my own fork, if interested I can add this to the pull request but that changes the scope slightly, and will publish containers under the repo owners name. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is small, just wanted to use this for my own site but I deploy my things using docker.
While working on docker I noticed that a pure port doesn't work, (i.e ./comma /data 9991), so I added in a check for that.
I do believe though that this may benefit from maybe having a github actions workflow to automatically build and push the code to a container image on tagged releases? I have some working examples already but I do not want to push that on you without you being good with it.
Then I wanted to check your implementation for comments, but also noticed that the link is dead, just replaced with a prefixed underscore.
That should be all, let me know if this needs any changes.