Skip to content

Update the URL for the pure javascript implementation, added a Dockerfile & fixed just a pure port not working - #6

Open
axodouble wants to merge 4 commits into
Dieterbe:masterfrom
axodouble:master
Open

Update the URL for the pure javascript implementation, added a Dockerfile & fixed just a pure port not working #6
axodouble wants to merge 4 commits into
Dieterbe:masterfrom
axodouble:master

Conversation

@axodouble

Copy link
Copy Markdown

This pull request is small, just wanted to use this for my own site but I deploy my things using docker.

While working on docker I noticed that a pure port doesn't work, (i.e ./comma /data 9991), so I added in a check for that.

I do believe though that this may benefit from maybe having a github actions workflow to automatically build and push the code to a container image on tagged releases? I have some working examples already but I do not want to push that on you without you being good with it.

Then I wanted to check your implementation for comments, but also noticed that the link is dead, just replaced with a prefixed underscore.

That should be all, let me know if this needs any changes.

@axodouble

axodouble commented Aug 4, 2026

Copy link
Copy Markdown
Author

I have also created this tree on my own fork, if interested I can add this to the pull request but that changes the scope slightly, and will publish containers under the repo owners name.
So if you want to inspect the result, they are tagged under ghcr.io/axodouble/comma:latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant