Fixed matching URL path to service type in Extensibility.AuthorizeOperationMessageProcessor #1140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 12, 2025 13:02
When the dictionary on the constructor of Extensibility.AuthorizeOperationMessageProcessor had its keys not all lowercase, it couldn't find the service type and, consequently, the operation
When the dictionary on the constructor of Extensibility.AuthorizeOperationMessageProcessor had its keys not all lowercase, it couldn't find the service type and, consequently, the operation
|
There is an option to make path insensitive (SoapCoreOption.CaseInsensitivePath). Would it be a good idea to use that to decide if comparison should be case-insensitive? Dictionary accepts a comparer in the constructor |
|
Thank you for pointing me to the option of supplying a comparer to Dictionary<,>. I removed the foreach that made each key lowercase and instead used the comparer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the caller of the constructor had the responsibility to make the path for the service to be lowercase. I modified the constructor to make the path lowercase as it is not obvious to the caller that this is necessary.