pre-processing new module update#19
pre-processing new module update#19zhuchloe wants to merge 5 commits intoDigitalBiomarkerDiscoveryPipeline:masterfrom
Conversation
| new = datetime.strptime(date, '') | ||
| df["new_date"] = datetime.strftime() | ||
|
|
||
| ini_time = "Jul 17 2019 11:49AM" |
There was a problem hiding this comment.
Why we are seeing a specific time here? Or should it be a comment?
|
The specific time is the one I used to test, should be commented out. Flirt
is not necessary here but on my local device I imported as much related as
I can to avoid the case that the environment doesn’t work.
…On Fri, Jul 1, 2022 at 00:07 Md Mobashir Hasan Shandhi < ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In data_conversion.py
<#19 (comment)>
:
> +# return delta
+# def convert_string(self,data):
+# return str()
+# def convert_list(self, data):
+# return list()
+# def convert_tuple(self, data):
+# return tuple()
+# def convert_set(self, data):
+# return set()
+"""
+lst = []
+for date in df:
+ new = datetime.strptime(date, '')
+df["new_date"] = datetime.strftime()
+
+ini_time = "Jul 17 2019 11:49AM"
Why we are seeing a specific time here? Or should it be a comment?
—
Reply to this email directly, view it on GitHub
<#19 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AS47RAW3XVXVYSSYZQXFF33VRZVIFANCNFSM5ZWN2PTQ>
.
You are receiving this because you authored the thread.Message ID:
<DigitalBiomarkerDiscoveryPipeline/Pre-process/pull/19/review/1025695115@
github.com>
|
|
|
||
|
|
||
| if __name__ == '__main__': | ||
| print(df) |
There was a problem hiding this comment.
Why are we seeing these lines of code here?
data_conversion.py
Outdated
|
|
||
| df = pd.read_csv("test_conversion.csv") | ||
| print(df) | ||
| def type_conversion(): |
There was a problem hiding this comment.
Are you going to pass any arguments to the function?
data_conversion.py
Outdated
| df = pd.read_csv("test_conversion.csv") | ||
| print(df) | ||
| def type_conversion(): | ||
| """Function that do data type conversion for time features |
There was a problem hiding this comment.
I think you are still working on this function. I don't think we are stating all the information needed here.
|
|
||
|
|
||
|
|
||
| if __name__ == '__main__': |
There was a problem hiding this comment.
Why are we using this line?
mobashir-shandhi
left a comment
mobashir-shandhi
left a comment
There was a problem hiding this comment.
Are you creating this code for the case study? How the full code is relevant to the pre-process module? For the case study, we need part of the code, you can just have that in the sample code for the case study. You do not need to create a separate .py file.
| ### Continued Development | ||
|
|
||
| ### Data type conversion functions: | ||
| data_conversion: with funciton used to convert the time feature in the csv file |
There was a problem hiding this comment.
Should it be: "date_conversion: function to convert the format of time in a csv file"?
|
new version of the data conversion functions |
2 participants
data_conversion