Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses an error with the Bluesky refresh token by updating the refresh logic.
- The refresh response body is now decoded from a String using the decodeJson extension.
- The necessary import for decodeJson was added.
Comments suppressed due to low confidence (1)
shared/src/commonMain/kotlin/dev/dimension/flare/data/network/bluesky/BlueskyService.kt:150
- The updated approach decodes the response body from a String using decodeJson. Consider adding explicit error handling for potential JSON decoding failures to prevent unexpected runtime exceptions.
val refreshed = refreshResponse.body<String>().decodeJson<RefreshSessionResponse>()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.