add social timeline support for misskey#1095
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces support for a new “Social” (hybrid) timeline on Misskey by adding a presenter, data-source loader, remote mediator, and associated UI configuration and resources.
- Adds
MisskeyHybridTimelinePresenterto select the hybrid timeline loader - Implements
HybridTimelineRemoteMediatorand exposes it viaMisskeyDataSource - Registers a new
HybridTimelineTabItemin tab settings and adds “Social” strings for Android and desktop
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| shared/src/commonMain/kotlin/dev/dimension/flare/ui/presenter/home/misskey/MisskeyHybridTimelinePresenter.kt | New presenter wiring hybridTimelineLoader |
| shared/src/commonMain/kotlin/dev/dimension/flare/data/datasource/misskey/MisskeyDataSource.kt | Added hybridTimelineLoader(), removed some defaults |
| shared/src/commonMain/kotlin/dev/dimension/flare/data/datasource/misskey/HybridTimelineRemoteMediator.kt | New remote mediator implementing hybrid logic |
| shared/src/androidJvmMain/kotlin/dev/dimension/flare/data/model/TabSettings.kt | Added Social title type and HybridTimelineTabItem |
| desktopApp/src/main/kotlin/dev/dimension/flare/data/model/TabSettings.kt | Imported new social_title resource |
| desktopApp/src/main/composeResources/values/strings.xml | Added <string name="social_title"> |
| app/src/main/res/values/strings.xml | Added <string name="home_tab_social_timeline_title"> |
| app/src/main/java/dev/dimension/flare/data/model/TabSettings.kt | Mapped LocalizedKey.Social to the new string |
Comments suppressed due to low confidence (2)
shared/src/commonMain/kotlin/dev/dimension/flare/data/datasource/misskey/MisskeyDataSource.kt:107
- Removing the
pagingKeyparameter fromlocalTimeline(and similarly frompublicTimeline) is a breaking API change; consider restoring this parameter or updating all callers to use a fixed key approach to avoid unintended paging collisions.
accountKey,
shared/src/commonMain/kotlin/dev/dimension/flare/data/datasource/misskey/MisskeyDataSource.kt:132
- Add tests for the new
hybridTimelineLoader()method (and its underlyingHybridTimelineRemoteMediator) to verify paging logic and ensure the social timeline loads correctly.
fun hybridTimelineLoader() =
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.