Skip to content

add social timeline support for misskey#1095

Merged
Tlaster merged 1 commit intomasterfrom
feature/misskey_social_timeline
Jul 14, 2025
Merged

add social timeline support for misskey#1095
Tlaster merged 1 commit intomasterfrom
feature/misskey_social_timeline

Conversation

@Tlaster
Copy link
Copy Markdown
Contributor

@Tlaster Tlaster commented Jul 14, 2025

No description provided.

@Tlaster Tlaster requested a review from Copilot July 14, 2025 05:44
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces support for a new “Social” (hybrid) timeline on Misskey by adding a presenter, data-source loader, remote mediator, and associated UI configuration and resources.

  • Adds MisskeyHybridTimelinePresenter to select the hybrid timeline loader
  • Implements HybridTimelineRemoteMediator and exposes it via MisskeyDataSource
  • Registers a new HybridTimelineTabItem in tab settings and adds “Social” strings for Android and desktop

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
shared/src/commonMain/kotlin/dev/dimension/flare/ui/presenter/home/misskey/MisskeyHybridTimelinePresenter.kt New presenter wiring hybridTimelineLoader
shared/src/commonMain/kotlin/dev/dimension/flare/data/datasource/misskey/MisskeyDataSource.kt Added hybridTimelineLoader(), removed some defaults
shared/src/commonMain/kotlin/dev/dimension/flare/data/datasource/misskey/HybridTimelineRemoteMediator.kt New remote mediator implementing hybrid logic
shared/src/androidJvmMain/kotlin/dev/dimension/flare/data/model/TabSettings.kt Added Social title type and HybridTimelineTabItem
desktopApp/src/main/kotlin/dev/dimension/flare/data/model/TabSettings.kt Imported new social_title resource
desktopApp/src/main/composeResources/values/strings.xml Added <string name="social_title">
app/src/main/res/values/strings.xml Added <string name="home_tab_social_timeline_title">
app/src/main/java/dev/dimension/flare/data/model/TabSettings.kt Mapped LocalizedKey.Social to the new string
Comments suppressed due to low confidence (2)

shared/src/commonMain/kotlin/dev/dimension/flare/data/datasource/misskey/MisskeyDataSource.kt:107

  • Removing the pagingKey parameter from localTimeline (and similarly from publicTimeline) is a breaking API change; consider restoring this parameter or updating all callers to use a fixed key approach to avoid unintended paging collisions.
            accountKey,

shared/src/commonMain/kotlin/dev/dimension/flare/data/datasource/misskey/MisskeyDataSource.kt:132

  • Add tests for the new hybridTimelineLoader() method (and its underlying HybridTimelineRemoteMediator) to verify paging logic and ensure the social timeline loads correctly.
    fun hybridTimelineLoader() =

@Tlaster Tlaster enabled auto-merge July 14, 2025 05:48
@Tlaster Tlaster merged commit f5757b4 into master Jul 14, 2025
5 checks passed
@Tlaster Tlaster deleted the feature/misskey_social_timeline branch July 14, 2025 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants