Skip to content

make ui more glassify#1101

Merged
Tlaster merged 8 commits intomasterfrom
feature/ui_glassify
Jul 17, 2025
Merged

make ui more glassify#1101
Tlaster merged 8 commits intomasterfrom
feature/ui_glassify

Conversation

@Tlaster
Copy link
Copy Markdown
Contributor

@Tlaster Tlaster commented Jul 15, 2025

No description provided.

@Tlaster Tlaster requested a review from Copilot July 17, 2025 02:59
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR integrates a glass-like styling across the app by adding a new Glassify component (powered by the Haze library), updating top app bars to a flexible large format with nested scrolling, and standardizing card shapes and clipping for list items.

  • Add Glassify composable and haze dependencies to deliver translucent “glass” surfaces.
  • Replace FlareTopAppBar with FlareLargeFlexibleTopAppBar and apply nested scroll behaviors.
  • Introduce ListCardModifier and PlatformShapes for consistent card clipping and shapes in lists.

Reviewed Changes

Copilot reviewed 62 out of 62 changed files in this pull request and generated no comments.

Show a summary per file
File Description
shared/ui/src/commonMain/kotlin/dev/dimension/flare/ui/screen/settings/AboutScreenContent.kt Added padding and clipped list items for a consistent “glass” look
shared/ui/component/src/commonMain/kotlin/dev/dimension/flare/ui/component/Glassify.kt New Glassify composable wrapping content in a hazeEffect box
shared/ui/component/src/commonMain/kotlin/dev/dimension/flare/ui/component/ListCardModifier.kt Introduced listCard modifier for clipping items based on position
shared/ui/component/src/commonMain/kotlin/dev/dimension/flare/ui/common/PagingStateExt.kt Added itemsIndexed extension to support index-aware paging content
shared/ui/component/src/jvmMain/kotlin/dev/dimension/flare/ui/theme/PlatformShapes.jvm.kt Provided actual extraSmall/small shapes but omitted other expecteds
Comments suppressed due to low confidence (3)

shared/ui/component/src/commonMain/kotlin/dev/dimension/flare/ui/common/PagingStateExt.kt:73

  • [nitpick] The use of it in key?.let { it(this, it) } shadows the lambda parameter in a confusing way; consider renaming the inner it in let to avoid shadowing and improve readability.
                    key?.let {

shared/ui/component/src/jvmMain/kotlin/dev/dimension/flare/ui/theme/PlatformShapes.jvm.kt:7

  • PlatformShapes.jvm.kt only provides extraSmall and small but misses actual implementations for large, topCardShape, bottomCardShape, listCardContainerShape, and listCardItemShape matching the expect in commonMain; this will cause a compilation error.
internal actual object PlatformShapes {

shared/ui/component/src/jvmMain/kotlin/dev/dimension/flare/ui/component/platform/PlatformListItem.jvm.kt:8

  • Actual signature of PlatformListItem in jvmMain does not match the expect signature in commonMain (missing default parameters for modifier, leadingContent, supportingContent, trailingContent), causing potential call-site mismatches.
internal actual fun PlatformListItem(

@Tlaster Tlaster marked this pull request as ready for review July 17, 2025 03:05
@Tlaster Tlaster merged commit 390efae into master Jul 17, 2025
5 checks passed
@Tlaster Tlaster deleted the feature/ui_glassify branch July 17, 2025 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants