Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR integrates a glass-like styling across the app by adding a new Glassify component (powered by the Haze library), updating top app bars to a flexible large format with nested scrolling, and standardizing card shapes and clipping for list items.
- Add Glassify composable and haze dependencies to deliver translucent “glass” surfaces.
- Replace FlareTopAppBar with FlareLargeFlexibleTopAppBar and apply nested scroll behaviors.
- Introduce ListCardModifier and PlatformShapes for consistent card clipping and shapes in lists.
Reviewed Changes
Copilot reviewed 62 out of 62 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| shared/ui/src/commonMain/kotlin/dev/dimension/flare/ui/screen/settings/AboutScreenContent.kt | Added padding and clipped list items for a consistent “glass” look |
| shared/ui/component/src/commonMain/kotlin/dev/dimension/flare/ui/component/Glassify.kt | New Glassify composable wrapping content in a hazeEffect box |
| shared/ui/component/src/commonMain/kotlin/dev/dimension/flare/ui/component/ListCardModifier.kt | Introduced listCard modifier for clipping items based on position |
| shared/ui/component/src/commonMain/kotlin/dev/dimension/flare/ui/common/PagingStateExt.kt | Added itemsIndexed extension to support index-aware paging content |
| shared/ui/component/src/jvmMain/kotlin/dev/dimension/flare/ui/theme/PlatformShapes.jvm.kt | Provided actual extraSmall/small shapes but omitted other expecteds |
Comments suppressed due to low confidence (3)
shared/ui/component/src/commonMain/kotlin/dev/dimension/flare/ui/common/PagingStateExt.kt:73
- [nitpick] The use of
itinkey?.let { it(this, it) }shadows the lambda parameter in a confusing way; consider renaming the inneritinletto avoid shadowing and improve readability.
key?.let {
shared/ui/component/src/jvmMain/kotlin/dev/dimension/flare/ui/theme/PlatformShapes.jvm.kt:7
- PlatformShapes.jvm.kt only provides extraSmall and small but misses actual implementations for large, topCardShape, bottomCardShape, listCardContainerShape, and listCardItemShape matching the expect in commonMain; this will cause a compilation error.
internal actual object PlatformShapes {
shared/ui/component/src/jvmMain/kotlin/dev/dimension/flare/ui/component/platform/PlatformListItem.jvm.kt:8
- Actual signature of PlatformListItem in jvmMain does not match the expect signature in commonMain (missing default parameters for modifier, leadingContent, supportingContent, trailingContent), causing potential call-site mismatches.
internal actual fun PlatformListItem(
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.