-
Notifications
You must be signed in to change notification settings - Fork 45
update pagingconfig usage #1103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
8 changes: 8 additions & 0 deletions
8
...ed/src/androidMain/kotlin/dev/dimension/flare/data/datasource/microblog/Paging.android.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| package dev.dimension.flare.data.datasource.microblog | ||
|
|
||
| import androidx.paging.PagingConfig | ||
|
|
||
| internal actual val pagingConfig: PagingConfig = | ||
| PagingConfig( | ||
| pageSize = 20, | ||
| ) |
10 changes: 10 additions & 0 deletions
10
shared/src/appleMain/kotlin/dev/dimension/flare/data/datasource/microblog/Paging.apple.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| package dev.dimension.flare.data.datasource.microblog | ||
|
|
||
| import androidx.paging.PagingConfig | ||
|
|
||
| internal actual val pagingConfig: PagingConfig = | ||
| PagingConfig( | ||
| pageSize = 20, | ||
| initialLoadSize = 20, | ||
| enablePlaceholders = false, | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -30,6 +30,8 @@ import kotlinx.coroutines.launch | |
| import kotlinx.coroutines.withContext | ||
| import kotlin.coroutines.CoroutineContext | ||
|
|
||
| internal expect val pagingConfig: PagingConfig | ||
|
|
||
| @OptIn(ExperimentalPagingApi::class) | ||
| internal fun timelinePager( | ||
| pageSize: Int, | ||
|
|
@@ -41,7 +43,7 @@ internal fun timelinePager( | |
| ): Flow<PagingData<UiTimeline>> { | ||
| val pagerFlow = | ||
| Pager( | ||
| config = PagingConfig(pageSize = pageSize), | ||
| config = pagingConfig, | ||
| remoteMediator = mediator, | ||
| pagingSourceFactory = { | ||
| database.pagingTimelineDao().getPagingSource( | ||
|
|
@@ -189,7 +191,7 @@ internal fun <T : Any> memoryPager( | |
| mediator: BaseRemoteMediator<Int, T>, | ||
| ): Flow<PagingData<T>> = | ||
| Pager( | ||
| config = PagingConfig(pageSize = pageSize), | ||
| config = pagingConfig, | ||
|
||
| remoteMediator = mediator, | ||
| pagingSourceFactory = { | ||
| MemoryPagingSource( | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,7 +3,6 @@ package dev.dimension.flare.data.datasource.xqt | |
| import androidx.paging.ExperimentalPagingApi | ||
| import androidx.paging.LoadType | ||
| import androidx.paging.Pager | ||
| import androidx.paging.PagingConfig | ||
| import androidx.paging.PagingData | ||
| import androidx.paging.PagingState | ||
| import androidx.paging.cachedIn | ||
|
|
@@ -40,6 +39,7 @@ import dev.dimension.flare.data.datasource.microblog.ProfileTab | |
| import dev.dimension.flare.data.datasource.microblog.StatusEvent | ||
| import dev.dimension.flare.data.datasource.microblog.createSendingDirectMessage | ||
| import dev.dimension.flare.data.datasource.microblog.memoryPager | ||
| import dev.dimension.flare.data.datasource.microblog.pagingConfig | ||
| import dev.dimension.flare.data.datasource.microblog.relationKeyWithUserKey | ||
| import dev.dimension.flare.data.datasource.microblog.timelinePager | ||
| import dev.dimension.flare.data.network.xqt.XQTService | ||
|
|
@@ -192,7 +192,7 @@ internal class XQTDataSource( | |
| ): Flow<PagingData<UiTimeline>> { | ||
| if (type == NotificationFilter.All) { | ||
| return Pager( | ||
| config = PagingConfig(pageSize = pageSize), | ||
| config = pagingConfig, | ||
|
||
| ) { | ||
| NotificationPagingSource( | ||
| locale = "en", | ||
|
|
@@ -574,7 +574,7 @@ internal class XQTDataSource( | |
| pageSize: Int, | ||
| ): Flow<PagingData<UiUserV2>> = | ||
| Pager( | ||
| config = PagingConfig(pageSize = pageSize), | ||
| config = pagingConfig, | ||
| ) { | ||
| SearchUserPagingSource( | ||
| service = service, | ||
|
|
@@ -585,7 +585,7 @@ internal class XQTDataSource( | |
|
|
||
| override fun discoverUsers(pageSize: Int): Flow<PagingData<UiUserV2>> = | ||
| Pager( | ||
| config = PagingConfig(pageSize = pageSize), | ||
| config = pagingConfig, | ||
| ) { | ||
| TrendsUserPagingSource( | ||
| service, | ||
|
|
@@ -600,7 +600,7 @@ internal class XQTDataSource( | |
|
|
||
| override fun discoverHashtags(pageSize: Int): Flow<PagingData<UiHashtag>> = | ||
| Pager( | ||
| config = PagingConfig(pageSize = pageSize), | ||
| config = pagingConfig, | ||
| ) { | ||
| TrendHashtagPagingSource( | ||
| service, | ||
|
|
@@ -1067,7 +1067,7 @@ internal class XQTDataSource( | |
| pageSize: Int, | ||
| ): Flow<PagingData<UiUserV2>> = | ||
| Pager( | ||
| config = PagingConfig(pageSize = pageSize), | ||
| config = pagingConfig, | ||
| ) { | ||
| FollowingPagingSource( | ||
| service = service, | ||
|
|
@@ -1082,7 +1082,7 @@ internal class XQTDataSource( | |
| pageSize: Int, | ||
| ): Flow<PagingData<UiUserV2>> = | ||
| Pager( | ||
| config = PagingConfig(pageSize = pageSize), | ||
| config = pagingConfig, | ||
| ) { | ||
| FansPagingSource( | ||
| service = service, | ||
|
|
@@ -1486,7 +1486,7 @@ internal class XQTDataSource( | |
|
|
||
| override fun directMessageList(scope: CoroutineScope): Flow<PagingData<UiDMRoom>> = | ||
| Pager( | ||
| config = PagingConfig(pageSize = 20), | ||
| config = pagingConfig, | ||
| remoteMediator = | ||
| DMListRemoteMediator( | ||
| service = service, | ||
|
|
@@ -1510,7 +1510,7 @@ internal class XQTDataSource( | |
| scope: CoroutineScope, | ||
| ): Flow<PagingData<UiDMItem>> = | ||
| Pager( | ||
| config = PagingConfig(pageSize = 20), | ||
| config = pagingConfig, | ||
| remoteMediator = | ||
| DMConversationRemoteMediator( | ||
| service = service, | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||
|---|---|---|---|---|
|
|
@@ -8,7 +8,6 @@ import androidx.paging.ExperimentalPagingApi | |||
| import androidx.paging.LoadState | ||||
| import androidx.paging.LoadStates | ||||
| import androidx.paging.Pager | ||||
| import androidx.paging.PagingConfig | ||||
| import androidx.paging.PagingData | ||||
| import androidx.paging.cachedIn | ||||
| import androidx.paging.compose.collectAsLazyPagingItems | ||||
|
|
@@ -24,6 +23,7 @@ import dev.dimension.flare.common.onSuccess | |||
| import dev.dimension.flare.common.toPagingState | ||||
| import dev.dimension.flare.data.database.cache.CacheDatabase | ||||
| import dev.dimension.flare.data.datasource.microblog.contains | ||||
| import dev.dimension.flare.data.datasource.microblog.pagingConfig | ||||
| import dev.dimension.flare.data.repository.AccountRepository | ||||
| import dev.dimension.flare.data.repository.LocalFilterRepository | ||||
| import dev.dimension.flare.model.AccountType | ||||
|
|
@@ -107,7 +107,7 @@ public abstract class TimelinePresenter : | |||
| ): Flow<PagingData<UiTimeline>> { | ||||
| val pagerFlow = | ||||
| Pager( | ||||
| config = PagingConfig(pageSize = pageSize), | ||||
| config = pagingConfig, | ||||
|
||||
| remoteMediator = mediator, | ||||
| pagingSourceFactory = { | ||||
| database.pagingTimelineDao().getPagingSource( | ||||
|
|
@@ -143,7 +143,7 @@ public abstract class TimelinePresenter : | |||
| pageSize: Int = 20, | ||||
|
||||
| pageSize: Int = 20, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 8 additions & 0 deletions
8
shared/src/jvmMain/kotlin/dev/dimension/flare/data/datasource/microblog/Paging.jvm.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| package dev.dimension.flare.data.datasource.microblog | ||
|
|
||
| import androidx.paging.PagingConfig | ||
|
|
||
| internal actual val pagingConfig: PagingConfig = | ||
| PagingConfig( | ||
| pageSize = 20, | ||
| ) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pageSize parameter is now ignored since pagingConfig has a fixed pageSize. Consider removing the pageSize parameter from this function or documenting that it's no longer used.