Skip to content

Fix Windows cookie crash after composewebview alpha-13 bump #1852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tlaster merged 3 commits into from
Mar 9, 2026
Merged

Fix Windows cookie crash after composewebview alpha-13 bump #1852

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
98f1cac
Initial plan
Copilot Mar 9, 2026
f8c07ca
Fix compilation error: replace nativeWebView with cookieManager.getCo…
Copilot Mar 9, 2026
b029aec
Fix Windows cookie exception: use WryWebViewPanel directly instead of…
Copilot Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions desktopApp/src/main/kotlin/dev/dimension/flare/ui/screen/serviceselect/WebViewLoginScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import androidx.compose.runtime.LaunchedEffect
import androidx.compose.ui.Modifier
import io.github.kdroidfilter.webview.web.WebView
import io.github.kdroidfilter.webview.web.rememberWebViewState
import io.github.kdroidfilter.webview.wry.WryWebViewPanel
import io.ktor.http.Url
import kotlinx.coroutines.delay
import kotlin.time.Duration.Companion.seconds
Expand All @@ -18,7 +19,7 @@ internal fun WebViewLoginScreen(
) {
val state = rememberWebViewState(url)
LaunchedEffect(Unit) {
state.cookieManager.removeAllCookies()
(state.webView?.nativeWebView as? WryWebViewPanel)?.clearAllCookies()
val urlData = Url(url)
val actualUrl =
urlData.protocol.name
Expand All @@ -27,7 +28,10 @@ internal fun WebViewLoginScreen(
.plus("/")
while (true) {
delay(2.seconds)
val cookies = state.nativeWebView.getCookiesForUrl(actualUrl)
val cookies =
(state.webView?.nativeWebView as? WryWebViewPanel)
?.getCookiesForUrl(actualUrl)
.orEmpty()
if (callback.invoke(cookies.joinToString("; ") { "${it.name}=${it.value}" })) {
onBack.invoke()
break
Expand Down