Feat/first commit #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+46
to
+47
| LAST_TAG=$(git describe --tags $(git rev-list --tags --max-count=1)) | ||
| LAST_COMMIT=$(git log -1 --format='%H') |
There was a problem hiding this comment.
Consider adding error handling or a default value in case no tags are found. Without this, an empty LAST_TAG may lead to unexpected behavior in the version bump logic.
Suggested change
| LAST_TAG=$(git describe --tags $(git rev-list --tags --max-count=1)) | |
| LAST_COMMIT=$(git log -1 --format='%H') | |
| LAST_TAG=$(git describe --tags $(git rev-list --tags --max-count=1) 2>/dev/null || echo "v0.0.0") | |
| LAST_COMMIT=$(git log -1 --format='%H') | |
| if [ "$LAST_TAG" = "v0.0.0" ]; then | |
| echo "No tags found. Defaulting LAST_TAG to v0.0.0" | |
| fi |
| run: | | ||
| git push --follow-tags | ||
| - name: "Install Poetry" | ||
| run: pip install poetry |
There was a problem hiding this comment.
[nitpick] To ensure consistency in build environments, consider specifying a particular version of Poetry when installing.
Suggested change
| run: pip install poetry | |
| run: pip install poetry==1.5.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.