Always resolve icons relative to the crate, not the cwd of the CLI #5020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ealmloff
added
bug
nicoburns
approved these changes
Nov 24, 2025
Contributor
nicoburns
left a comment
nicoburns
left a comment
There was a problem hiding this comment.
Looks good. Not sure if we need need to consider this a breaking change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue @nicoburns ran into with the CLI bundling in workspaces with the blitz browser pr. If you run the bundler from the workspace, the CLI tries to resolve the icon path relative to the workspace instead of relative to the crate. This PR changes the behavior to always resolve icon paths relative to the crate