fix(fullstack): preserve untyped server function error status codes#5663
Open
constantin-jais wants to merge 1 commit into
Open
fix(fullstack): preserve untyped server function error status codes#5663constantin-jais wants to merge 1 commit into
constantin-jais wants to merge 1 commit into
Conversation
The MakeAxumError impls for anyhow::Error and shared CapturedError build an ErrorPayload with the right status (downcasting ServerFnError and HttpError) but then hardcode the HTTP response status to 500. The RPC payload told clients 400/401 while the wire status said 500 — and examples/07-fullstack/handling_errors.rs documents HttpError::bad_request(...)? as producing an HTTP 400. Set the response status from the already-computed payload code, exactly like the typed Result<T, HttpError> and Result<T, StatusCode> paths do. Adds regression tests for the three untyped paths (anyhow + HttpError, anyhow + ServerFnError, shared CapturedError + HttpError). Claude-Session: https://claude.ai/code/session_015toc12d2m9EyacRBuFQuuZ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation