Skip to content

deps: bump sphinx to 7.0 #1020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 2, 2023
Merged

deps: bump sphinx to 7.0 #1020

merged 2 commits into from
May 2, 2023

Conversation

onerandomusername
Copy link
Member

No description provided.

@onerandomusername onerandomusername added t: documentation Improvements or additions to documentation/examples s: needs review Issue/PR is awaiting reviews t: dependencies Addition/update/removal of dependencies labels May 2, 2023
@onerandomusername onerandomusername added this to the disnake v2.9 milestone May 2, 2023
@onerandomusername onerandomusername requested a review from shiftinv May 2, 2023 16:49
shiftinv
shiftinv approved these changes May 2, 2023
View reviewed changes
Copy link
Member

@shiftinv shiftinv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff'd the old and new versions, no noteworthy changes. It seems to build quite a bit faster (38s vs 30s), that's definitely a nice bonus c:
lgtm!

@onerandomusername onerandomusername enabled auto-merge (squash) May 2, 2023 22:15
@shiftinv shiftinv disabled auto-merge May 2, 2023 22:17
@shiftinv shiftinv merged commit 73158aa into master May 2, 2023
@shiftinv shiftinv deleted the deps/sphinx-7 branch May 2, 2023 22:28
@onerandomusername onerandomusername removed the s: needs review Issue/PR is awaiting reviews label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shiftinv shiftinv shiftinv approved these changes

Assignees
No one assigned
Labels
t: dependencies Addition/update/removal of dependencies t: documentation Improvements or additions to documentation/examples
Projects
disnake
Status: Done
Milestone
disnake v2.9
Development

Successfully merging this pull request may close these issues.
2 participants
@onerandomusername @shiftinv