Skip to content

docs: Clarify docs about the on_member_update event #1024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 7, 2023
Merged

docs: Clarify docs about the on_member_update event #1024

merged 4 commits into from
May 7, 2023

Conversation

Snipy7374
Copy link
Collaborator

Summary

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@shiftinv shiftinv added t: documentation Improvements or additions to documentation/examples s: needs review Issue/PR is awaiting reviews labels May 6, 2023
@shiftinv shiftinv added this to the disnake v2.9 milestone May 6, 2023
@shiftinv
Copy link
Member

shiftinv commented May 6, 2023

Seems good, thanks c:
Could you also update on_raw_member_update and the two corresponding Event member docstrings?

@Snipy7374
Copy link
Collaborator Author

Seems good, thanks c: Could you also update on_raw_member_update and the two corresponding Event member docstrings?

9f9c96a

@shiftinv shiftinv enabled auto-merge (squash) May 7, 2023 01:20
@shiftinv shiftinv merged commit 00c94d7 into DisnakeDev:master May 7, 2023
@onerandomusername onerandomusername removed the s: needs review Issue/PR is awaiting reviews label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shiftinv shiftinv shiftinv approved these changes

Assignees
No one assigned
Labels
t: documentation Improvements or additions to documentation/examples
Projects
disnake
Status: Done
Milestone
disnake v2.9
Development

Successfully merging this pull request may close these issues.

On timeout listener
3 participants
@Snipy7374 @shiftinv @onerandomusername