Skip to content

fix(ci): pin urllib3<2 for pdm #1026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2023
Merged

fix(ci): pin urllib3<2 for pdm #1026

merged 1 commit into from
May 7, 2023

Conversation

shiftinv
Copy link
Member

@shiftinv shiftinv commented May 6, 2023

Summary

supersedes #1022

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@shiftinv shiftinv added t: dependencies Addition/update/removal of dependencies t: meta Changes to the project itself (CI, configs, etc.) skip news labels May 6, 2023
@shiftinv shiftinv added this to the disnake v2.9 milestone May 6, 2023
@shiftinv shiftinv requested a review from onerandomusername May 6, 2023 22:22
@shiftinv shiftinv mentioned this pull request May 6, 2023
Closed
8 tasks
@shiftinv shiftinv force-pushed the deps/pdm-pin-urllib branch from f4ec805 to 8a05f19 Compare May 6, 2023 22:40
onerandomusername
onerandomusername approved these changes May 7, 2023
View reviewed changes
Copy link
Member

@onerandomusername onerandomusername left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@onerandomusername onerandomusername merged commit 232b316 into master May 7, 2023
@onerandomusername onerandomusername deleted the deps/pdm-pin-urllib branch May 7, 2023 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onerandomusername onerandomusername onerandomusername approved these changes

Assignees
No one assigned
Labels
skip news t: dependencies Addition/update/removal of dependencies t: meta Changes to the project itself (CI, configs, etc.)
Projects
disnake
Status: Done
Milestone
disnake v2.9
Development

Successfully merging this pull request may close these issues.
2 participants
@shiftinv @onerandomusername