Skip to content

fix: always deserialize application_flags in ready event #1027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 21, 2023

Conversation

shiftinv
Copy link
Member

@shiftinv shiftinv commented May 7, 2023

Summary

Trying to access client.application_flags when you created a client with Client(application_id=...) previously resulted in an AttributeError, since the logic was gated by application_id not being set in the first place.

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@shiftinv shiftinv added s: needs review Issue/PR is awaiting reviews t: bugfix labels May 7, 2023
@shiftinv shiftinv added this to the disnake v2.9 milestone May 7, 2023
@shiftinv shiftinv enabled auto-merge (squash) May 21, 2023 17:27
@shiftinv shiftinv merged commit a331c30 into master May 21, 2023
@shiftinv shiftinv deleted the fix/deserialize-application-flags branch May 21, 2023 17:32
@onerandomusername onerandomusername removed the s: needs review Issue/PR is awaiting reviews label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants