Skip to content

fix(converter): fix clean_content not using nicknames in some cases #1029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 24, 2023

Conversation

shiftinv
Copy link
Member

@shiftinv shiftinv commented May 7, 2023

Summary

Tiny bug I noticed the other day - in the clean_content converter, user objects always took precedence over members, which resulted in usernames being used instead of nicknames.
This only happens when the user ID isn't part of ctx.message.mentions, which is the general case with interactions.

To reproduce:

# with members intent enabled, invoke `/test arg:@mention`
@bot.slash_command()
async def test(inter: disnake.CommandInteraction, arg: str) -> None:
    await inter.send(await commands.clean_content().convert(inter, arg))

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@shiftinv shiftinv added s: needs review Issue/PR is awaiting reviews t: bugfix labels May 7, 2023
@shiftinv shiftinv added this to the disnake v2.9 milestone May 7, 2023
@shiftinv shiftinv requested a review from onerandomusername May 7, 2023 16:16
@shiftinv shiftinv enabled auto-merge (squash) May 24, 2023 14:48
@shiftinv shiftinv disabled auto-merge May 24, 2023 14:56
@shiftinv shiftinv merged commit 9c08363 into master May 24, 2023
@shiftinv shiftinv deleted the fix/converter-clean-display-name branch May 24, 2023 14:57
@onerandomusername onerandomusername removed the s: needs review Issue/PR is awaiting reviews label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants