fix(converter): fix clean_content
not using nicknames in some cases
#1029
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Tiny bug I noticed the other day - in the
clean_content
converter, user objects always took precedence over members, which resulted in usernames being used instead of nicknames.This only happens when the user ID isn't part of
ctx.message.mentions
, which is the general case with interactions.To reproduce:
Checklist
pdm lint
pdm pyright