Skip to content

typing(Thread): improve annotations #1031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 11, 2023

Conversation

Victorsitou
Copy link
Member

Summary.

https://canary.discord.com/channels/808030843078836254/847513235536216085/1104843888205770752

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@Victorsitou Victorsitou added s: needs review Issue/PR is awaiting reviews t: refactor/typing/lint Refactors, typing changes and/or linting changes skip news labels May 7, 2023
@Victorsitou Victorsitou added this to the disnake v2.9 milestone May 7, 2023
@Skelmis
Copy link
Contributor

Skelmis commented May 8, 2023

Link provided isn't viewable to us regular folk, care to tl;dr?

@Victorsitou
Copy link
Member Author

Link provided isn't viewable to us regular folk, care to tl;dr?

tl;dr: basically this

if not isinstance(ctx.channel, DMChannel): # DMChannel does not have name
   name = ctx.channel.name # Pylance(reportUnknownMemberType): Type of "name" is unknown, str | Unknown.

Copy link
Member

@shiftinv shiftinv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@shiftinv shiftinv changed the title typing(Thread): improve typing(Thread): improve annotations May 9, 2023
@shiftinv shiftinv enabled auto-merge (squash) May 11, 2023 12:54
@shiftinv shiftinv merged commit 473bafb into DisnakeDev:master May 11, 2023
@onerandomusername onerandomusername removed the s: needs review Issue/PR is awaiting reviews label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news t: refactor/typing/lint Refactors, typing changes and/or linting changes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants