Skip to content

docs: exclude pins() from voice/stage channels #1034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 11, 2023
Merged

Conversation

shiftinv
Copy link
Member

@shiftinv shiftinv commented May 9, 2023

Summary

Resolves the documentation side of #1033. Voice/Stage channels having a pins() method isn't necessarily an issue, especially since the API returns an empty list instead of throwing an error, but this is still something that can be solved by a refactor in the future.

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@shiftinv shiftinv added t: documentation Improvements or additions to documentation/examples s: needs review Issue/PR is awaiting reviews labels May 9, 2023
@shiftinv shiftinv added this to the disnake v2.9 milestone May 9, 2023
@shiftinv shiftinv linked an issue May 9, 2023 that may be closed by this pull request
@shiftinv shiftinv enabled auto-merge (squash) May 11, 2023 11:52
@shiftinv shiftinv merged commit 424f9cd into master May 11, 2023
@shiftinv shiftinv deleted the docs/voice-pins branch May 11, 2023 11:59
@onerandomusername onerandomusername removed the s: needs review Issue/PR is awaiting reviews label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t: documentation Improvements or additions to documentation/examples
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

disnake.VoiceChannel.pins()
3 participants