Skip to content

fix(enum): deprecates Party Type enum (#1023) #1035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Jun 13, 2023
Merged

fix(enum): deprecates Party Type enum (#1023) #1035

merged 17 commits into from
Jun 13, 2023

Conversation

KnownBlackHat
Copy link
Contributor

@KnownBlackHat KnownBlackHat commented May 10, 2023 •
edited
Loading

Summary

Deprecates the PartyType enum

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

Victorsitou
Victorsitou requested changes May 10, 2023
View reviewed changes
Copy link
Member

@Victorsitou Victorsitou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The enum should be deprecated rather than removed to avoid breaking changes

@Victorsitou Victorsitou added s: needs review Issue/PR is awaiting reviews t: deprecation Deprecation of existing features labels May 10, 2023
@Victorsitou Victorsitou added this to the disnake v2.9 milestone May 10, 2023
@KnownBlackHat
Copy link
Contributor Author

yep doing that rn

@KnownBlackHat KnownBlackHat requested a review from Victorsitou May 10, 2023 01:53
@shiftinv shiftinv linked an issue May 10, 2023 that may be closed by this pull request
Consider deprecating PartyType enum #1023
Closed
@KnownBlackHat
chore: add changelog
13eb1a7 
Signed-off-by: Known Black Hat <[email protected]>
@KnownBlackHat KnownBlackHat force-pushed the fix/depricate-party-type-enum branch from 0ae9b85 to 59b44c1 Compare May 11, 2023 18:36
@KnownBlackHat KnownBlackHat force-pushed the fix/depricate-party-type-enum branch from 59b44c1 to d6db29d Compare May 11, 2023 18:45
shiftinv
shiftinv reviewed May 15, 2023
View reviewed changes
Copy link
Member

@shiftinv shiftinv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add a deprecation note (.. deprecated:: 2.9 etc.) below here, similar to other deprecation notes?

disnake/docs/api/voice.rst

Lines 111 to 113 in 473bafb

.. class:: PartyType
Represents the type of a voice channel activity/application.

@KnownBlackHat KnownBlackHat requested a review from shiftinv May 15, 2023 16:46
@KnownBlackHat KnownBlackHat changed the title fix(enum): remove Party Type enum (#1023) fix(enum): deprecates Party Type enum (#1023) May 15, 2023
@KnownBlackHat KnownBlackHat marked this pull request as draft May 22, 2023 22:26
@KnownBlackHat KnownBlackHat marked this pull request as ready for review May 24, 2023 20:20
@shiftinv shiftinv enabled auto-merge (squash) June 13, 2023 14:54
@shiftinv shiftinv merged commit 425a780 into DisnakeDev:master Jun 13, 2023
@onerandomusername onerandomusername removed the s: needs review Issue/PR is awaiting reviews label Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shiftinv shiftinv shiftinv approved these changes

@Victorsitou Victorsitou Victorsitou approved these changes

Assignees
No one assigned
Labels
t: deprecation Deprecation of existing features
Projects
disnake
Status: Done
Milestone
disnake v2.9
Development

Successfully merging this pull request may close these issues.

Consider deprecating PartyType enum
4 participants
@KnownBlackHat @shiftinv @Victorsitou @onerandomusername