Skip to content

feat: support animated field for emojis in reaction remove events #1040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 9, 2023
Merged

feat: support animated field for emojis in reaction remove events #1040

merged 5 commits into from
Jun 9, 2023

Conversation

shiftinv
Copy link
Member

Summary

Adds handling for emoji.animated in parse_message_reaction_remove and parse_message_reaction_remove_emoji, which was added a couple weeks ago.

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@shiftinv shiftinv added t: enhancement New feature t: api support Support of Discord API features s: needs review Issue/PR is awaiting reviews labels May 22, 2023
@shiftinv shiftinv added this to the disnake v2.9 milestone May 22, 2023
onerandomusername
onerandomusername approved these changes Jun 9, 2023
View reviewed changes
Copy link
Member

@onerandomusername onerandomusername left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@onerandomusername onerandomusername enabled auto-merge (squash) June 9, 2023 17:39
@onerandomusername onerandomusername merged commit 094343d into master Jun 9, 2023
@onerandomusername onerandomusername deleted the feature/reaction-events-animated branch June 9, 2023 17:54
@onerandomusername onerandomusername removed the s: needs review Issue/PR is awaiting reviews label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onerandomusername onerandomusername onerandomusername approved these changes

Assignees
No one assigned
Labels
t: api support Support of Discord API features t: enhancement New feature
Projects
disnake
Status: Done
Milestone
disnake v2.9
Development

Successfully merging this pull request may close these issues.
2 participants
@shiftinv @onerandomusername