Skip to content

docs: misc fixes/clarifications #1052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 20, 2023
Merged

docs: misc fixes/clarifications #1052

merged 8 commits into from
Jun 20, 2023

Conversation

shiftinv
Copy link
Member

Summary

A collection of random documentation changes I've gathered over time that don't really deserve their own PRs.

references:

If anyone else has other trivial documentation updates, feel free to suggest them here.

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@shiftinv shiftinv added t: documentation Improvements or additions to documentation/examples s: needs review Issue/PR is awaiting reviews skip news labels Jun 16, 2023
@shiftinv shiftinv added this to the disnake v2.9 milestone Jun 16, 2023
Victorsitou
Victorsitou reviewed Jun 16, 2023
View reviewed changes
Sharp-Eyes
Sharp-Eyes approved these changes Jun 18, 2023
View reviewed changes
Copy link
Member

@Sharp-Eyes Sharp-Eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine, kudos on the create_guild/guild_builder clarifications.

onerandomusername
onerandomusername approved these changes Jun 19, 2023
View reviewed changes
Copy link
Member

@onerandomusername onerandomusername left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, will merge later

@onerandomusername onerandomusername added do not merge Don't merge. Don't. and removed s: needs review Issue/PR is awaiting reviews do not merge Don't merge. Don't. labels Jun 19, 2023
@onerandomusername onerandomusername merged commit 0c193b5 into master Jun 20, 2023
@onerandomusername onerandomusername deleted the docs/misc-updates branch June 20, 2023 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sharp-Eyes Sharp-Eyes Sharp-Eyes approved these changes

@Victorsitou Victorsitou Victorsitou approved these changes

@onerandomusername onerandomusername onerandomusername approved these changes

Assignees
No one assigned
Labels
skip news t: documentation Improvements or additions to documentation/examples
Projects
disnake
Status: Done
Milestone
disnake v2.9
Development

Successfully merging this pull request may close these issues.
4 participants
@shiftinv @Sharp-Eyes @Victorsitou @onerandomusername