Skip to content

docs(channel): clarify ForumChannel.create_thread return type #1215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 10, 2024

Conversation

shiftinv
Copy link
Member

@shiftinv shiftinv commented Aug 7, 2024

Summary

Resolves #1198, by adding a .. note:: and explicitly documenting the ThreadWithMessage namedtuple.

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@shiftinv shiftinv added t: documentation Improvements or additions to documentation/examples skip news labels Aug 7, 2024
@shiftinv shiftinv added this to the disnake v2.10 milestone Aug 7, 2024
@shiftinv shiftinv enabled auto-merge (squash) August 10, 2024 13:07
@shiftinv shiftinv merged commit 409140f into master Aug 10, 2024
28 checks passed
@shiftinv shiftinv deleted the docs/forum-create-thread-callout branch August 10, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news t: documentation Improvements or additions to documentation/examples
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Missing class in documentation may lead to confusion
2 participants