fix(sku)!: change SKU.subscriptions to be a sync method

changelog/1274.breaking.rst

@@ -0,0 +1 @@
+:meth:`SKU.subscriptions` mistakenly returned a coroutine, unlike other iterator methods. Instead of ``async for x in await sku.subscriptions():``, correct usage now is ``async for x in sku.subscriptions():``.

changelog/1274.bugfix.rst

@@ -0,0 +1 @@
+Change :meth:`SKU.subscriptions` to be a synchronous method (returning an async iterator), to match other iterator methods.

disnake/sku.py

@@ -87,17 +87,15 @@ def flags(self) -> SKUFlags:
         """:class:`SKUFlags`: Returns the SKU's flags."""
         return SKUFlags._from_value(self._flags)
 
-    async def subscriptions(
+    def subscriptions(
         self,
         user: Snowflake,
         *,
         limit: Optional[int] = 50,
         before: Optional[SnowflakeTime] = None,
         after: Optional[SnowflakeTime] = None,
     ) -> SubscriptionIterator:
-        """|coro|
-
-        Retrieves an :class:`.AsyncIterator` that enables receiving subscriptions for the SKU.
+        """Retrieves an :class:`.AsyncIterator` that enables receiving subscriptions for the SKU.
 
         All parameters, except ``user``, are optional.