page_info_fetch: Fix PHP 8.5 'cannot use bool as array' warns#1586
Merged
Conversation
page_info_cache() returns a list of 3 items, or false depending on if there's more information. false cannot be used in a destructuring assignment, and PHP 8.5 warns about this. (Spotted while running smoke tests in an Ubuntu 26.04/PHP 8.5 VM)
Member
|
Oh, thanks! If you wanted to add PHP 8.5 to our CI test matrix (in another PR) I wouldn't be sad about that -- although I don't know what else lurks in there so it might be a can of worms. |
cpeel
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
page_info_fetch()returns a list of 3 items, or false depending on if there's more information. false cannot be used in a destructuring assignment, and PHP 8.5 warns about this.(Spotted while running smoke tests in an Ubuntu 26.04/PHP 8.5 VM)