add support for percentage width and height styles #828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
(I should specify, this was for IE8--I came up against issue this working with r2d3) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: elements styled with percentage widths or heights (e.g.
width: 100%) throw an error on the linecs.clip = "rect(0 " + width + " " + height + " 0)";Proposed solution: apply to the canvas whatever width/height are provided, then if width/height are percentage strings, read the computed (pixel) width/height using offsetWidth and offsetHeight, passing those values to the cs.clip property.
Not extensively tested, but fixed the bugs I was coming up against. Hopefully someone with more knowledge of this project can review and see if this is a suitable fix.