fix where the gradient fill would not find the defining element, when url contains anchor (#) information #950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ment because it is referred to in an absolute manner, and the url would include anchor (#) tags the url has been replaced to document.location.pathname, which is the relative reference I am not sure of the implications of this modifications, but the fix worked beautifully for me.
|
See also #939, please merge this fix. We are still stuck on an old version of Raphael (2.1.2 with bower or even 2.1.0 with browserify) where this doesn't occur and we would really like to use the new features of Raphael. |
Contributor
|
This is causing problems for us using Raphaël in an Angular app. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the gradient fill wouldn't find its defining elements from the svg defs section, because it is referred to in an absolute manner, and the url would include anchor (#) tags.
the url has been replaced with "document.location.pathname", which is the relative reference, and seems to be working.
I am not sure of the implications of this modifications, but the fix worked beautifully for me.