Fixing Wrong Generated First Set #157
Open
+103
−49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #138
Hi this is my first github contribution and i feel honored to be help to you as you were to me in your amazing courses.
1-
I fixed the wrong generated first sets from productions that have the nullable LHS(derive ε) appear in firstOf(rhs).
the solution is to register the Non-Terminals that derive epsilon directly (A->ε) before calculating the first sets.
added test case for this issue.
2-
i also spotted a function typo 'getOrignialSymbol' -> 'getOriginalSymbol'