Feat/guard coverage engine#59
Merged
Merged
Conversation
Move EXTERNAL_CALL_PATTERNS, MOCK_TEST_KEYWORDS, is_external_facing, has_external_call, and is_mock_or_test into constants.rs so they can be reused by other engines without duplication.
Add bfs_collect helper, transitive_internal_callees (BFS along internal edges), and external_callers (BFS backward collecting public/external nodes). These enable the guard engine to detect transitive risk and bypass paths.
Detect missing, inconsistent, and bypassable reentrancy guards: - Missing guards on high-risk functions (external + ext call + state write) - Inconsistent coverage (contract uses guards but skips some functions) - Bypass paths (internal fn reachable from guarded and unguarded callers) Includes 12 unit tests covering all detection categories, edge cases, and filtering behavior. Closes #58
Hoist CallGraph so guard engine can borrow it, run guard coverage analysis after call graph stage, track guard_candidates in pipeline stats, add field to CachedEngineResult, add guard weight (0.55) to confidence scorer, and bump engine cache version to v5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.