Skip to content

Conversation

@brutalchrist
Copy link
Contributor

@brutalchrist brutalchrist commented Jun 25, 2025

Summary

This PR replaces node-sass (LibSass) with the officially maintained Dart Sass (sass) to improve compatibility, maintenance, and install reliability.

Motivation

  • Fixes: Resolves Issue #126
  • Root cause of the error:
    • node-sass is obsolete and relies on node-gyp to compile native code
    • Python 3.12+ has removed the distutils module
    • Your macOS 24.4.0 environment likely ships with Python 3.12+ by default, so ModuleNotFoundError: No module named 'distutils' is raised

Why

  • Better Node.js support: Pure-JS implementation that works across all current Node versions without native builds
  • Officially maintained: Dart Sass is the reference implementation, receiving regular updates and new features
  • Simplified installs: Removes the need for Python’s distutils, Xcode CLI or Windows build tools

What Changed

  • Dependencies:
    • Removed node-sass
    • Added sass (latest stable)
  • Build scripts:
    - "build:css": "node-sass src/styles/ -o dist/styles/"
    + "build:css": "sass src/styles:dist/styles --no-source-map"
    
image

@sajjadmrx sajjadmrx changed the base branch from main to develop July 1, 2025 07:42
@sajjadmrx sajjadmrx merged commit ecb2360 into DnsChanger:develop Jul 1, 2025
2 checks passed
Copy link

@hosein203 hosein203 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DNS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Not installed in mac with M2 chip

3 participants