Scripts: Fail on error - #327
Merged
Merged
Conversation
offa
marked this pull request as ready for review
February 28, 2026 20:45
offa
commented
Feb 28, 2026
| _install_doctest() { | ||
| cd "$REPO_DIR" | ||
| git clone --depth=1 --branch=v2.4.11 https://github.com/doctest/doctest | ||
| git clone --depth=1 --branch=v2.4.12 https://github.com/doctest/doctest |
Collaborator
Author
There was a problem hiding this comment.
Fixes this Mac OS error present in current builds:
CMake Error at CMakeLists.txt:1 (cmake_minimum_required):
-- Configuring incomplete, errors occurred!
Compatibility with CMake < 3.5 has been removed from CMake.
Update the VERSION argument <min> value. Or, use the <min>...<max> syntax
to tell CMake that the project requires at least <min> but has been updated
to work with policies introduced by <max> or earlier.
Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.
Error: could not find CMAKE_PROJECT_NAME in Cache
offa
commented
Feb 28, 2026
Owner
|
Ah, very good findings. 👍 Thanks a lot. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fail the scripts on error to avoid silently ignoring.