Fix image download redirect -> follow 30* from http to https#274
Open
reapier wants to merge 4 commits intoDoctorD1501:masterfrom
Open
Fix image download redirect -> follow 30* from http to https#274reapier wants to merge 4 commits intoDoctorD1501:masterfrom
reapier wants to merge 4 commits intoDoctorD1501:masterfrom
Conversation
Author
|
Please add me as a Collaborator |
Collaborator
|
Thank you for your PR. I read the commits but I don't understand what do you want to do in the commit f4e7abf . Can you explain what is the idea ? For the collaborator addition, i don't have access to this repository settings so i cannot add someone as a collaborator, only @DoctorD1501 is able to do such a thing. |
Wizell
requested changes
Jun 14, 2019
Collaborator
Wizell
left a comment
There was a problem hiding this comment.
Thank you for this patch but i see the following changes as required before merging:
- Hard coding the user agent is not a good idea. Better keep the same user agent as the previous request or use the utility files to get a random user agent
- the referer is not properly handled as for the nth redirect, the referer should be the nth-1 url not the given intial referer
- 307 and 308 HTTP RC code check might also be required
- i would rather avoid the use a while(true) even if the current code i don't see obvious flow it makes reading and cross checking more complex and is easier to make mistakes like moving the "break;" which would create an infinite loop
Wizell
requested changes
Jun 14, 2019
Collaborator
Wizell
left a comment
There was a problem hiding this comment.
Please update the tests accordingly. The file is OnePondoParsingProfileTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes 1pondo scraper not working -- resolve #206
Scraping genres on 1pondo videos -- resolve #47