Skip to content

Bound nonce history and tighten nonce replay checks - #1275

Merged
llinsss merged 2 commits into
DogStark:mainfrom
chindosunday:fix/nonce-history-bounded
Aug 31, 2026
Merged

Bound nonce history and tighten nonce replay checks#1275
llinsss merged 2 commits into
DogStark:mainfrom
chindosunday:fix/nonce-history-bounded

Conversation

@chindosunday

Copy link
Copy Markdown
Contributor

Pull Request

Related Issue

Closes #[issue_id]

closes #1164
closes #1165
closes #1166
closes #1167

Description of Changes

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code refactoring (no functional changes)
  • Performance improvement
  • Security fix

Testing Done

  • All existing tests pass (cargo test)
  • New tests added for new functionality
  • Tested on Stellar testnet
  • Gas optimization verified (if applicable)
  • Manually verified expected behavior

Test Environment

  • Rust version:
  • Stellar CLI version:
  • OS:

Checklist

  • My code follows the project's code style guidelines (cargo fmt)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README, API docs, etc.)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • No hardcoded secrets, keys, or credentials are included in this PR
  • No plaintext encryption keys or sensitive data are exposed in the code
  • Input validation is properly implemented for all public functions
  • Authentication checks are in place for state-changing operations
  • I have read and followed the Contributing Guide

Security Considerations

Screenshots / Logs (if applicable)

Additional Notes

@drips-wave

drips-wave Bot commented Aug 29, 2026

Copy link
Copy Markdown

@chindosunday Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@llinsss
llinsss merged commit 163792c into DogStark:main Aug 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants