-
-
Notifications
You must be signed in to change notification settings - Fork 74
Fix: Update Tamga init parameters to match v1.4.0 #201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Update Tamga init parameters to match v1.4.0 #201
Conversation
WalkthroughThe initialization of the Changes
Estimated code review effort2 (~15 minutes) Possibly related issues
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (4)
app/db/analytics.dbis excluded by!**/*.dbapp/db/comments.dbis excluded by!**/*.dbapp/db/posts.dbis excluded by!**/*.dbapp/db/users.dbis excluded by!**/*.db
📒 Files selected for processing (1)
app/utils/log.py(1 hunks)
4e80cb2 to
2828e32
Compare
|
Nice catch @ancientlaw0! We already handled this in #199, but since that’s taking a while to merge, we can go ahead with this one to avoid errors on main. Your PR has a few small issues and some unnecessary configs though, so I’ll refactor and merge it in. Thanks again! |
Bumped Tamga package version to 1.4.0 in pyproject.toml. Updated log.py to use 'console_output' instead of 'colored_output' and removed unused Tamga parameters for improved compatibility with the new version.
DogukanUrker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
Thanks for merging! I noticed you updated the Tamga version and tweaked the config — makes perfect sense. I’ll make sure to align dependencies properly and double-check compatibility in future PRs. |
|
No problem! Really appreciate your effort, and I’d love to see more PRs from you in the future. Thanks again! 🚀🚀 |
Fixes #200
Summary
This PR fixes a bug in
utils/log.pywhere theTamgalogger was being initialized using outdated parameter names (logToFile,logToConsole, andlogFile). These parameters are invalid in the currently requiredtamga>=1.2.0version as defined inpyproject.toml.The application was throwing:
TypeError: Tamga.init() got an unexpected keyword argument 'logToFile'
This is due to a mismatch between the expected arguments in
Tamgav1.4.0 and the ones used in the project.What Was Changed
Old initialization (invalid):
New initialization (valid as per Tamga 1.4.0 docs):
Why This Fix Matters
This fix makes the app runnable out-of-the-box for anyone installing dependencies via uv or pip, and using the compatible Tamga version (>=1.2.0 as specified). Without this fix, the project throws a TypeError and fails to start.
Summary by CodeRabbit
Summary by CodeRabbit